Skip to content

Cleanup Project Euler Problem 01 #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 10, 2020
Merged

Cleanup Project Euler Problem 01 #2900

merged 3 commits into from
Oct 10, 2020

Conversation

drts01
Copy link
Contributor

@drts01 drts01 commented Oct 6, 2020

Describe your change:

(replacing PR #2893)

  • clean up docstrs
  • improve coding-style

 

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Part of Issues: #2786, #2510

dhruvmanila
dhruvmanila requested changes Oct 6, 2020
View reviewed changes
@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 6, 2020
@dhruvmanila dhruvmanila removed the awaiting changes A maintainer has requested changes to this PR label Oct 10, 2020
@dhruvmanila dhruvmanila merged commit 927e14e into TheAlgorithms:master Oct 10, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@drts01 @stokhos
Cleanup Project Euler Problem 01 (TheAlgorithms#2900)
ee33185 
* mv str statement into docstr

* rename var to avoid redefining builtin

* clean up module docstr
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@drts01
Cleanup Project Euler Problem 01 (TheAlgorithms#2900)
1bcf110 
* mv str statement into docstr

* rename var to avoid redefining builtin

* clean up module docstr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drts01 @dhruvmanila